Which is better when check list is null ?
var newList;
if(newList!= null)
or newList.Any()
In the above code, sometimes I check not null and sometimes I use Any(), I don't know which one is best practice and why ?
Any advice?
Thanks in advance
These are not the same.
Any
will throw an exception if used on a null
reference.
With lists, you can think of .Any()
as .Count() != 0
(*)
You may have to check for both, and you have to do the null check before calling Any()
on your IEnumerable
.
One way is to check them for both in one strike with the null-safe navigation ?.
as in Thierry V's answer.
But sometimes you want to throw a custom Exception if you have a null value that you are not supposed to have, and treat an empty list as a correct input, so it all depends on the context.
Just remember that these are different.
(*) : as noticed in a comment, .Any()
is not actually implemented as Count() == 0
. For lists, it's functionally equivalent, but it's best practice to use Any()
to test if an IEnumerable
is empty or not, because Count()
might need to go through all the elements.
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With