Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

When should I initialize a view controller using initWithNibName?

When should I use init: and when should I use initWithNibName:bundle: when creating a view controller?

like image 316
Anthony Glyadchenko Avatar asked Feb 08 '10 18:02

Anthony Glyadchenko


4 Answers

-initWithNibName:bundle: is the designated initializer for UIViewController. Something should eventually call it. That said, and despite Apple's examples (which favor brevity over maintainability in many cases), it should never be called from outside the view controller itself.

You will often see code like this:

MYViewController *vc = [[MYViewController alloc] initWithNibName:@"Myview" bundle:nil];

I say this is incorrect. It puts implementation details (the name of the NIB and the fact that a NIB is even used) into the caller. That breaks encapsulation. The correct way to do this is:

MYViewController *vc = [[MYViewController alloc] init];

Then, in MYViewController:

- (instancetype)init
{
   self = [super initWithNibName:@"Myview" bundle:nil];
   if (self != nil)
   {
       // Further initialization if needed
   }
   return self;
}

- (instancetype)initWithNibName:(NSString *)nibName bundle:(NSBundle *)bundle
{
    NSAssert(NO, @"Initialize with -init");
    return nil;
}

This moves the key implementation details back into the object, and prevents callers from accidentally breaking encapsulation. Now if you change the name of the NIB, or move to programmatic construction, you fix it in one place (in the view controller) rather than in every place the view controller is used.

like image 178
Rob Napier Avatar answered Nov 15 '22 19:11

Rob Napier


Use initWithNibName: bundle: if you are... initializing with a nib file! That is, a file that you made using Interface Builder.

If you aren't using IB to layout your views, you can just use init.

like image 9
bpapa Avatar answered Nov 15 '22 19:11

bpapa


You can just call init, as long as the xib has the same name as the view controller class. The encapsulation is not necessary. This saves typing, but may not serve clarity.

 NUDMainViewController *mainVC = [[NUDMainViewController alloc] init];
like image 2
Kiet Nguyen Avatar answered Nov 15 '22 18:11

Kiet Nguyen


using init when there is no nib/xib file, e.g. UI are created by coding

using initWithNibName , if we have an nib/xib or same controller share by more than 1 nib/xib

if ([[UIDevice currentDevice] userInterfaceIdiom] == UIUserInterfaceIdiomPhone) {
     self.viewController = [[ViewController alloc] initWithNibName:@"ViewController_iPhone" bundle:nil];
 } else {
    self.viewController = [[ViewController alloc] initWithNibName:@"ViewController_iPad" bundle:nil];
 }

that's what I think..

like image 1
JosephT Avatar answered Nov 15 '22 20:11

JosephT