Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

What's the best way to check if class instance variable is set in Python?

Tags:

python

I have a variable which may or may not get a value in the instance:

class EC():
   __init__(self, a=False):
   ...
   if a: self.__var = ...

Later I want to check if the __var exists in the instance. Because prepending __ to the name changes the internal name to _EC__var the checking code becomes a little bit messy:

if ''.join(['_',self.__class__.__name__,'__name']) in self.__dict__: ...

Is code above considered normal or not? If not what are the preferred alternatives?

One option I can think of is to give __var some value anyway, for example:

_no_value = object()
...
   def __init__(self, a):
      self.__var = _no_value
      ...
      if a: self.__var = ...

So later I can compare __var to _no_value instead of a mess with internal variables.

like image 522
Phoenix Avatar asked Aug 01 '13 14:08

Phoenix


3 Answers

You've forgotten the EAFP principle:

try:
    value = self.__var
except AttributeError:
    # do something else

If you're determined to use a sentinel, you can combine it with a class variable:

class EC():
    __var = object():
    ...
    if self.__var is not EC.__var:
        ...
like image 126
ecatmur Avatar answered Oct 16 '22 12:10

ecatmur


Just use hasattr(self, '_var') to see if it exists - it may be set to None but it will exist if hasattr says it does.

E.g.:

>>> class a():
...   def __init__(self):
...      self.a = 3
...      self._a_ = 4
...      self.__a__ = 'Fred'
...
>>> A=a()
>>> hasattr(a, 'a')
False
>>> hasattr(A, 'a')
True
>>> hasattr(A, '_a_')
True
>>> hasattr(A, '__a__')
True
>>> hasattr(A, '__b__')
False
>>>
like image 12
Steve Barnes Avatar answered Oct 16 '22 12:10

Steve Barnes


Just set it to None on the class:

 class EC():
    __var = None

    __init__(self, a=False):
        ...
        if a: self.__var = ...

then test for if self.__var is not None.

If None should be a valid value for the attribute, use a different singleton sentinel:

_sentinel = object()

 class EC():
    __var = _sentinel

    __init__(self, a=False):
        ...
        if a: self.__var = ...

and test for if self.__var is not _sentinel.

This way, all references to __var are properly rewritten to include the class name.

The other path would be to not use double-underscore names for your attributes. __var should only be used for attributes you want to namespace to your specific class so that subclasses do not accidentally clobber it with their own attributes.

In other words, do not use double-underscore names unless you really understand what they are for and actually need it. Any code that is not part of a framework for wider consumption by unknown third parties? Just stick to single underscores instead.

like image 4
Martijn Pieters Avatar answered Oct 16 '22 13:10

Martijn Pieters