What scope does a using statement have without curly braces

Question

I inherited the following code:

    using (var dataAccessConnection = da.GetConnection()) //no opening curly brace here     using (var command = new SqlCommand(sql, dataAccessConnection.Connection))     {         command.CommandType = CommandType.Text;         using (var sqlDataReader = command.ExecuteReader(CommandBehavior.CloseConnection))         {             while (sqlDataReader.Read())             {                 rueckgabe.Add(new Myclass                                   {                                       Uid = Guid.NewGuid(),                                       ImportVersionUid = versionUid,                                       MyProperty = Convert.ToInt32(sqlDataReader["MyProperty"])                                         });                    }         }         command.Connection.Close();         dataAccessConnection.Connection.Close();     } 

Looking at the code I expexted an opening curly brace after the using clause.

The code compiles and does what it is expected to do. The application behaves unpredictable. At some time it cant access the Database server.

Does this code make sense? Does dataAccessConnection have the rigth scope?

Answer 1

Beginning with C# 8.0, the using keyword can be used as an attribute in the variable declarations of disposable objects (Reference). The semantics is as you would expect -- the objects are auto-disposed at the end of the scope.

        public class Disposable : IDisposable         {             string name;              public Disposable(string name)             {                 this.name = name;             }              public void Dispose()             {                 Console.WriteLine(name + " disposed");             }              public void Identify()             {                 Console.WriteLine(name);             }              static void Main(string[] args)             {                 using Disposable d1 = new Disposable("Using 1");                 Disposable d2 = new Disposable("No Using 2");                 using Disposable d3 = new Disposable("Using 3");                 Disposable d4 = new Disposable("No Using 4");                 d1.Identify();                 d2.Identify();                 d3.Identify();                 d4.Identify();             }         } 

Output

 Using 1 No Using 2 Using 3 No Using 4 Using 3 disposed Using 1 disposed 

Answer 2

using statements without explicit curly braces apply only to the following statement.

using (Idisp1)     // use it  // it's disposed 

Thus, when chained, they work the same way. The second using here acts as a single statement.

using (Idisp1)     using (Idisp2)     {      } 

Commenter stakx suggested that formatting to make it clear how the compiler reads the using blocks. In reality, these would usually be formatted as the OP encountered:

using (Idisp1) using (Idisp2) {  } 

That is equivalent to this:

using (Idisp1) {     using (Idisp2)     {      } } 

Notice that the first at the top is always the last to dispose. Thus, in all previous examples, Idisp2.Dispose() is called before Idisp1.Dispose(). That isn't relevant in many cases where you would do something like this, but I believe you should always be aware of what your code will do and make the informed decision not to care.

An example of this is when reading a web page:

HttpWebRequest req = ...;  using (var resp = req.GetResponse()) using (var stream = resp.GetResponseStream()) using (var reader = new StreamReader(stream)) {     TextBox1.Text = reader.ReadToEnd(); // or whatever } 

We get the response, get the stream, get the reader, read the stream, dispose the reader, dispose the stream, and finally, dispose the response.

Note, as commenter Nikhil Agrawal pointed out, that this is a language feature regarding blocks that is not specific to the using keyword. For example, the same applies to if blocks:

if (condition)     // may or may not execute  // definitely will execute 

Versus

if (condition1)     if (condition2)        // will execute if both are true  // definitely will execute 

Although you should never, of course, use if statements this way as it's dreadful to read, but I thought it'd help you understand the using case. I'm personally very okay with chaining using blocks.