Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

VSTS rejected pull request completion workflow

Tags:

azure-devops

We have VSTS pull requests (PR's) set up to require 2 reviewers before the request can complete.

This scenario happened today:

  1. Pull request created with 2 reviewers
  2. One reviewer accepted the PR and the other reviewer rejected
  3. The author fixed and pushed up the code
  4. The reviewer who had rejected the code approved
  5. The PR completed successfully without the first approver seeing the update

We need the original approvals and rejections to be reset when the updated code comes in. Is this possible out of the box?

like image 731
GaTechThomas Avatar asked Sep 13 '26 10:09

GaTechThomas


1 Answers

The option you want now exists. (I believe it was added sometime after you posted the question.) Under the branch policies, check the box labeled "Reset code reviewer votes when there are new changes." See documentation here

So far as I know this resets all votes, regardless of whether they were acceptances or rejections. So in cases where an optional reviewer rejected the previous version, there's a bit of a risk that someone might then complete the pull request before that reviewer verifies that their reason for rejection was adequately addressed.

like image 123
Tim Goodman Avatar answered Sep 16 '26 06:09

Tim Goodman



Donate For Us

If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!