Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Using reflection to change static final File.separatorChar for unit testing?

Specifically, I'm trying to create a unit test for a method which requires uses File.separatorChar to build paths on windows and unix. The code must run on both platforms, and yet I get errors with JUnit when I attempt to change this static final field.

Anyone have any idea what's going on?

Field field = java.io.File.class.getDeclaredField( "separatorChar" );
field.setAccessible(true);
field.setChar(java.io.File.class,'/');

When I do this, I get

IllegalAccessException: Can not set static final char field java.io.File.separatorChar to java.lang.Character

Thoughts?

like image 252
Stefan Kendall Avatar asked Mar 18 '10 23:03

Stefan Kendall


4 Answers

From the documentation for Field.set:

If the underlying field is final, the method throws an IllegalAccessException unless setAccessible(true) has succeeded for this field and this field is non-static.

So at first it seems that you are out of luck, since File.separatorChar is static. Surprisingly, there is a way to get around this: simply make the static field no longer final through reflection.

I adapted this solution from javaspecialist.eu:

static void setFinalStatic(Field field, Object newValue) throws Exception {
    field.setAccessible(true);

    // remove final modifier from field
    Field modifiersField = Field.class.getDeclaredField("modifiers");
    modifiersField.setAccessible(true);
    modifiersField.setInt(field, field.getModifiers() & ~Modifier.FINAL);

    field.set(null, newValue);
}

I've tested it and it works:

setFinalStatic(File.class.getField("separatorChar"), '#');
System.out.println(File.separatorChar); // prints "#"

Do exercise extreme caution with this technique. Devastating consequences aside, the following actually works:

setFinalStatic(Boolean.class.getField("FALSE"), true);
System.out.format("Everything is %s", false); // "Everything is true"

Important update: the above solution does not work in all cases. If the field is made accessible and read through Reflection before it gets reset, an IllegalAccessException is thrown. It fails because the Reflection API creates internal FieldAccessor objects which are cached and reused (see the java.lang.reflect.Field#acquireFieldAccessor(boolean) implementation). Example test code which fails:

Field f = File.class.getField("separatorChar"); f.setAccessible(true); f.get(null);
// call setFinalStatic as before: throws IllegalAccessException
like image 140
polygenelubricants Avatar answered Nov 11 '22 01:11

polygenelubricants


Try invoking on an instance of file not on an instance of class File

E.g.

File file = ...;    
field.setChar(file,'/');

You could also try http://code.google.com/p/jmockit/ and mock the static method FileSystem.getFileSystem(). (don't know if you can mock static variables, normally those hacks shouldn't be necessary -> write oo code and use 'only' mockito)

like image 44
Karussell Avatar answered Nov 11 '22 02:11

Karussell


Just use / everywhere when constructing Files. I've been doing that for 13 years and never had a problem. Nothing to test either.

like image 2
user207421 Avatar answered Nov 11 '22 01:11

user207421


I realise this doesn't answer your question directly, but Apache Commons FileNameUtils will do cross-platform filename construction, and may save you writing your own class to do this.

like image 1
Brian Agnew Avatar answered Nov 11 '22 01:11

Brian Agnew