Menu
I forked a GitHub repository and made some changes on my fork and submited a pull request but the owners of the original GitHub repository asked for some changes which they asked me for in the pull request. I assumed that adding additional changes to my fork will cause them to show up in the current pull request but to my surprise I can't see my changes in the pull request.
This is what I did after generating the original pull request:
git commit -m "these are my suggested changes in pull request"
git push
I can see changes on my own fork but I don't understand why I can't see any changes in the pull request.
Does anyone know what I need to do for my changes to show up in the current pull request?
I'd really appreciate your help.
277
The pull request will be updated automatically with the additional commits. This is because the pulled request represents a diff with your fork's branch. If you go to the pull request page(the one where you and others can comment on your pull request) then the Commits tab should have your additional commit(s).
If you're working on the pull request, you have to make the necessary changes. To do so, you go back to your forked repository and update the same branch you used to submit the pull request. In this case, this will be the development branch.
The current way to update a pull request is to click on the “Edit” button along the other pull request action buttons. This will bring you to the update pull request page where you can make changes to the title, description, reviewers and specify whether to close the branch after the pull request has been merged.
It sounds like your dev branch is behind master by a few commits, you will need get the latest changes from master into your branch (either by performing a merge or rebase). Once your dev branch has your latest changes from master, you diff should only show the newest changes in your dev branch.
You need to be sure to be in the same branch as the one you used for your pull request.
As mentioned here
The pull request will automatically add the new commits at the bottom of the pull request discussion (ie, it's already there, scroll down!)
If the pull request is still open, you should see your new commit there.
If not, contact GitHub support: there might be some synchronization issue.
188
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With
