Unreachable code detected in case statement

Question

I have a code:

    protected override bool ProcessCmdKey(ref Message msg, Keys keyData)
    {
        switch (keyData)
        {
            case Keys.Alt|Keys.D1:

                if (this._condition1)
                {
                    return true;
                }
                else
                {
                    return base.ProcessCmdKey(ref msg, keyData);
                }

                break;

            case Keys.Control |Keys.U:

                if (this._condition2)
                {
                    return true;
                }
                else
                {
                    return base.ProcessCmdKey(ref msg, keyData);
                }

                break;

            default:

                return base.ProcessCmdKey(ref msg, keyData);
        }

        return true;

It gives me "unreachable code detected" warning on breaks.

Is it good practice not to use break operator here ? I don't want to turn off "unreachable code detected" warning.

PS: There are many case in my ProcessCmdKey method.

Answer 1

There are three unreachable statements in your code, first two are the break statements and the last one int he last line "return true" is also unreachable, I dont know whether C# compiler detects that or not, but logically there is no way last return statement will also be reached.

There are multiple ways to solve this issue,

1. Store a temp variable, called bool retVal, keep retVal and break your switch case and at the end of function return retVal.
2. If you return value before break, break statement is useless.

Better Design Way

If you return values within switch cases, it may be difficult to analyze your code later on by you or someone else, usually it is better to keep a return value temp variable and return it at end of function, that becomes easier to debug and understand the code for new coder.

Switch can be complicated, and more returns within switch may not have better control, if you want to implement logging, debugging, returns from cases could be complicated. And it becomes way to difficult browsing the logic flow graphs.

So it is better to avoid return altogather from case, but still it depends on situtations as well, one needs to make an intelligent decision here.

Answer 2

break is not necessary if all paths in a case statement end with a return. Do not use it then, otherwise you will get the mentioned warning.