Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Unexpected block statement surrounding arrow body

I'm using "eslint-config-airbnb": "^6.1.0", to keep my JavaScript clean.

My linter is unhappy with what seems to be legitimate code:

enter image description here

It seems like this might be an ongoing issue. Does anyone have any suggestions for an OCD developer on how to address this in the meantime? Perhaps disabling this rule or otherwise?

like image 497
ilrein Avatar asked Mar 18 '16 20:03

ilrein


3 Answers

The block statement isn't needed for a single expression.

this.state.todos.filter(filterTodo => filterTodo !== todo);
like image 52
Kevin B Avatar answered Oct 23 '22 12:10

Kevin B


To add on Kevin answer, the error is related to your eslint configuration. This said, if arrow-body-style option is set to true, OP is correct. An other example would be something like this :

    return this.state.greetings.map((name) => {
        return <HelloWorld key={name} name={name} />;
    });

Without arrow-body-style option, block statement ( { return ...} ) is not needed as per Kevin answer.

This actually open a new question as to which style is more appropriate.

For further references : http://eslint.org/docs/rules/arrow-body-style

like image 40
Pobe Avatar answered Oct 23 '22 14:10

Pobe


If you really don't want to wrap arrow function inside block statement then you can turn off.

module.exports = {
  extends: "airbnb-base",
  rules: {
    "arrow-body-style": 0
  },
  "env": {
    "jest": true
  }
};
like image 3
Sagar Avatar answered Oct 23 '22 14:10

Sagar