In my factory method I use Switch statement to create concrete objects. This results in very high cyclomatic complexity. Here is a sample code:
private static UnitDescriptor createUnitDescriptor(string code)
{
switch (code)
{
case UnitCode.DEG_C:
return new UnitDescriptorDegC();
case UnitCode.DEG_F:
return new UnitDescriptorDegF();
:
:
default:
throw new SystemException(string.format("unknown code: {o}", code);
}
}
How can I refactor this to reduce cyclomatic complexity? If I use reflection to create objects or something else to build objects is it better than above method?
It's possible for you to use a Dictionary
to remove the switch
statement entirely:
class MyClass
{
private static Dictionary<string, Func<UnitDescriptor>> dict = new Dictionary<string, Func<UnitDescriptor>>();
static MyClass()
{
dict.Add(UnitCode.DEG_C, () => new UnitDescriptorDegC());
dict.Add(UnitCode.DEG_F, () => new UnitDescriptorDegF());
// Other mappings...
}
private static UnitDescriptor createUnitDescriptor(string code)
{
Func<UnitDescriptor> value;
if (dict.TryGetValue(code, out value))
{
return value();
}
throw new SystemException(string.Format("unknown code: {0}", code));
}
}
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With