Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

UIButton - alloc initWithFrame: vs. buttonWithType:

Given (arbitrarily):

CGRect frame = CGRectMake(0.0f, 0.0f, 100.0f, 30.0f);

What's the difference between the following two code snippets?

1.

    UIButton *button = [UIButton buttonWithType:UIButtonTypeCustom];
    button.frame = frame;

2.

    UIButton *button = [[[UIButton alloc] initWithFrame:frame] autorelease];
like image 777
ma11hew28 Avatar asked Jun 05 '11 21:06

ma11hew28


3 Answers

I think they're equivalent. Haha! Trick question you sneaky little punk!

Reasoning

  1. -buttonWithType: returns an autoreleased UIButton object.

  2. +[NSObject alloc] defaults scalar instance variables to 0, so buttonType should be 0, or UIButtonTypeCustom.

Pros & Cons

  1. You could argue that it's clearer to use -buttonWithType: and set buttonType explicitly and that it's safer in case Apple changes UIButtonTypeCustom to be 1 instead of 0 (which will most certainly never happen).

  2. On the other hand, you could also argue that it's clear & safe enough to use -initWithFrame. Plus, many of the Xcode sample projects, such as "TheElements" & "BubbleLevel," use this approach. One advantage is that you can explicitly release the UIButton before the run loop for your application's main thread has drained its autorelease pool. And, that's why I prefer option 2.

like image 83
ma11hew28 Avatar answered Nov 10 '22 08:11

ma11hew28


I would strongly suggest using the first approach (+buttonWithType), because that's the only way to specify the button type.

If you +alloc and -initWithFrame:, the buttonType is set to some standard value (not sure which, and this could change in later versions of the SDK) and you can't change the type afterwards because the buttonType property is read only.

like image 23
Thomas Müller Avatar answered Nov 10 '22 09:11

Thomas Müller


The main (maybe the only) difference is in memory management: as you said, buttonWithType returns an autoreleased UIButton. This way you don't have to worry about releasing it. On the other hand, you don't own it, so you cannot release it when you want to (except, of course, if you drain the autorelease pool).
Calling explicitly [[UIButton alloc] initWithFrame:frame], instead, you dynamically alloc your button, so you own it and you're responsible for releasing it.
If you plan to retain your button for some reason then maybe you should consider the second solution, but if, as in this case, you are autoreleasing it immediately, there's no big difference between the two way of creating a button...

like image 2
Manlio Avatar answered Nov 10 '22 10:11

Manlio