Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

TypeError: Cannot read property 'findAll' of undefined (expressjs)

TypeError: Cannot read property 'findAll' of undefined (expressjs).

All functions (sequelize) are not working. All errors: Cannot read property 'sequelize method' ...

module.exports = function (sequelize, DataTypes) {
var User = sequelize.define('user', {
    email: {type: DataTypes.STRING(32), unique: true, allowNull: false},
});

return User;
};

Controller:

models  = require('./../models');

exports.index = function (request, response, next) {
    models.User.findAll({attributes: ['id', 'username']});
};
like image 842
Designlenta Gogo Avatar asked Jan 14 '16 17:01

Designlenta Gogo


3 Answers

I had the same issue, and the changes below worked for me. This might be useful for future users -

when you use the sequelize model you need to use the defined model class name, which is "user" instead of "User" in line findAll:

models  = require('./../models');
exports.index = function (request, response, next) {
    models.user.findAll({attributes: ['id', 'username']});
};

The "User" is a variable to which the sequelize definition is assigned and its not recognized outside that model definition. The "user" is the table name that is getting created as well as the sequelize model class name, and this needs to be used in any type of db query.

like image 153
Vaij Avatar answered Nov 15 '22 16:11

Vaij


You have created two instances of sequelize. One in models/index.js in line 12/14 and second instance in server script in line 19. And you start second instance, but in model you tried to use first instance.

Your model/index.js file is ok. In your server file add

var database = require('path/to/models');

change your db start to:

database.sequelize .authenticate() .then(function(err) { console.log('Connection has been established successfully.'); }, function (err) { console.log('Unable to connect to the database:', err); });

And you have to pass 'database' object to your controllers instead of models = require('./../models'); and from your controllers you have access to your model : database.User

like image 27
Krzysztof Sztompka Avatar answered Nov 15 '22 17:11

Krzysztof Sztompka


Your model/index.js looks fine. In your controller try findAll() method inside sequelize.sync().then(function () {

Here is my approach to the problem

nb: instead of models/index.js i have a similar db.js file inside config folder which having the dbconnection scripts and sequelize object.

My userController.js will look like (working code) :

var db = require('./../config/db'),
seq = db.seq,
Sequelize = db.Sequelize;

module.exports = function(app) {
    app.get('/getUsers',function(req,res){
        var Users = require('../models/UserModel')(app); //since i am binding to a single object - app
        seq.sync().then(function () {
            Users.findAll({
               attributes: ['usr_code', 'usr_name']
           }).then(function (users) {
                    users.forEach(function(user,index,arr){
                        console.log(user.usr_code);
                    });
                });
        });
    });

}

Hope this helps you. :)

like image 1
George Mathew Avatar answered Nov 15 '22 17:11

George Mathew