Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

try catch block for the unpack function

Tags:

php

Our apache error_log was recently filled up with lines similar to the following (about 50GB):

[Wed Feb 01 16:50:15 2012] [error] [client 123.123.123.123] PHP Warning:
unpack() [<a href='function.unpack'>function.unpack</a>]:  
 Type V: not enough input,  need 4, have 1
    in /var/www/vhosts/domain.com/httpdocs/imagecreatefrombmp.php on line 52

Line 52 in imagecreatefrombmp.bmp is as follows:

$COLOR = unpack("V",substr($IMG,$P,3).$VIDE);

This line is buried in a while loop.

If this issue happens again I want the code to quietly exit the while loop.

The problem is I cannot replicate the problem myself so I sort of need to solve it blind.

I've devised the following little solution. Would it serve the purpose? If the "Type V not input..." error occurs again would the try catch block catch it and return false?

    try{
        $COLOR = unpack("V",substr($IMG,$P,3).$VIDE);            
    }catch (Exception $e) {
        return FALSE;        
    }
like image 605
Haluk Avatar asked Feb 01 '12 22:02

Haluk


1 Answers

You can't catch a PHP error or warning as it is not an exception.

You can test, after calling unpack, if an error was raised with error_get_last(), but that's not really practical.

Another solution is to set an error handler to catch the warning, and then throw an ErrorException for that warning. You will then be able to use try/catch and return false;.

function my_error_handler($errno = 0, $errstr = null, $errfile = null, $errline = null) {
    // If error is suppressed with @, don't throw an exception
    if (error_reporting() === 0) {
        return true; // return true to continue through the others error handlers
    }
    throw new ErrorException($errstr, 0, $errno, $errfile, $errline);
}
set_error_handler('my_error_handler');

Attention: all you errors, warnings, notices, etc... will be converted to an exception. That can potentially crash your program if you had one of those before.

Now you can catch the exception:

try {
    $COLOR = unpack("V",substr($IMG,$P,3).$VIDE);            
} catch (ErrorException $e) {
    return false;        
}
like image 141
Matthieu Napoli Avatar answered Oct 17 '22 06:10

Matthieu Napoli