Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Troubling converting string to long long in C

I'm having trouble getting the atoll function to properly set a long long value in c. Here is my example:

#include <stdio.h>

int main(void) {
    char s[30] = { "115" };
    long long t = atoll(s);

    printf("Value is: %lld\n", t);

    return 0;
}

This prints: Value is: 0

This works though:

printf("Value is: %lld\n", atoll(s));

What is going on here?

like image 941
Justin Brown Avatar asked Mar 14 '13 19:03

Justin Brown


People also ask

How do I convert a string to a number in C++?

One effective way to convert a string object into a numeral int is to use the stoi() function. This method is commonly used for newer versions of C++, with is being introduced with C++11. It takes as input a string value and returns as output the integer version of it.


1 Answers

First, let's answer your question:

#include <stdio.h>
#include <stdlib.h>  // THIS IS WHAT YOU ARE MISSING


int main(void) {
    char s[30] = { "115" };
    long long t = atoll(s);

    printf("Value is: %lld\n", t);

    return 0;
}

Then, let's discuss and answer 'why?':

For compatibility with very old C programs (pre-C89), using a function without having declared it first only generates a warning from GCC, not an error (As pointed out by the first comment here, also implicit function declarations are allowed in C89, therefore generating an error would not be appropriate, that is another reason to why only a warning is generated). But the return type of such a function is assumed to be int (not the type specified in stdlib.h for atoll for instance), which is why the program executes unexpectedly but does not generate an error. If you compile with -Wall you will see that:

Warning: Implicit declaration of function atoll

This fact mostly shocks people when they use atof without including stdlib.h, in which case the expected double value is not returned.

NOTE: (As an answer to one of the comments of the question) This is the reason why the results of atoll might be truncated if the correct header is not included.

like image 173
meyumer Avatar answered Sep 24 '22 15:09

meyumer