Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Trouble with deep routes on a single-page app on Firebase hosting

(Updated below with a little more info)

We have a react-based single-page web app that lives on Firebase Hosting. We've been using hash-based routing up to this point (e.g. mysite.com/#/path/to/content). We introduced React Router, which allows us to have prettier URLs (e.g. mysite.com/path/to/content), but now the app doesn't load when we navigate directly to a deep route. Details below:

Using React Router required us to use URL Rewriting in Firebase Hosting. The directions are pretty straightforward--it seems like all you need to do is this:

"rewrites": [ 
    {
    "source": "**",
    "destination": "/index.html"
    }
]

...inside the firebase.json file. In fact, our complete firebase.json file is as follows:

{
"firebase": "",
"public": "dist",
"rules": "rules.json",
"ignore": [
    "firebase.json",
    "**/.*",
    "**/*.map",
    "**/node_modules/**"
],
"rewrites": [ 
    {
    "source": "**",
    "destination": "/index.html"
    }
]
}

Nothing too complicated there (we're doing firebase deploy -f in our build script, if you're wondering why the firebase argument is empty). The linked-to rules.json file is even simpler:

{
   "rules":{
   ".write":"true",
   ".read":"true"
 }
}

When I load the app by going to the base URL and start navigating around, everything is fine. If I go directly to a route at one level deep (e.g. mysite.com/path), that works too.

HOWEVER

If I go directly to a route at a deep level, or even to a top-level route with a trailing slash (e.g. mysite.com/path/ or mysite.com/path/to/content), then the app doesn't load.

Specifically, what happens is the index.html page loads, and then browser goes to load our webpack-created bundle.js file that is referenced in index.html, but what Firebase Hosting returns for that JS file is the content of the index.html file. So then, predictably, what we see in the browser console is this error:

Uncaught SyntaxError: Unexpected token <

...on line 1 of the "bundle file". If I view the content of the bundle file in Chrome's dev tools, line 1 of the bundle file is literally this:

<!doctype html>

...which is then followed by the rest of the HTML from the index.html file.

It seems like what's going on is the Firebase URL rewrite rule is saying "oh, you're trying to reference a JS file--I see I'm supposed to return the content of index.html for everything, so here you go". But that can't be the case all the time, or the site would never work under any circumstances. So why does it work if I start at the site root, but breaks if I paste in a deep URL to the app? I have zero idea.

If it helps, here's how my index.html file references the bundle file:

<script src="bundle.ce843ef7a2ae68e9e319.js"></script></body>

So it seems like a problem with Firebase hosting, but I could also see that maybe I don't understand React Router at some level, and so I've somehow screwed things up with the client-side code in such a way that it's forcing the server to return the wrong thing.

Here's me hoping it's some stupid configuration thing we're missing. Any help is appreciated!

Thanks!

UPDATE: I stripped down our app so that it only returns "hello, world", which bypasses all of the React-based stuff, including React Router, and the problem persists, so I no longer think this has anything to do with React-Router, though I suppose there's still a small chance this could have something to do with React.

like image 436
hairbo Avatar asked Feb 17 '16 22:02

hairbo


Video Answer


1 Answers

I encountered the same behavior but the problem was unrelated to bundle.js.

My rewrites section of firebase.json looked like this:

    "rewrites": [
      {
        "source": "**",
        "destination": "index.html"
      }
    ]

and I resolved the problem by using the root relative path instead of the relative path for index.html. (Thanks Ashu!)

    "rewrites": [
      {
        "source": "**",
        "destination": "/index.html"
      }
    ]
like image 110
Leslie Sage Avatar answered Sep 20 '22 14:09

Leslie Sage