Toolbar Item Click

Question

I am using toolbar in my app. Toolbar layout looks like this. I add imageButton inside toolbar as menu item. (Is that is a problem?) As I am new to Toolbar I don't know if this is the right way.

<?xml version="1.0" encoding="utf-8"?>
<android.support.v7.widget.Toolbar xmlns:android="http://schemas.android.com/apk/res/android"
android:id="@+id/toolbar"
android:layout_width="match_parent"
android:layout_gravity="top"
android:layout_height="@dimen/abc_action_bar_default_height_material"
android:minHeight="?attr/actionBarSize"
android:gravity="right"
android:background="?attr/colorPrimaryDark">


<ImageButton
    android:src="@drawable/ic_action_social_share"
    android:layout_width="48dp"
    android:layout_height="48dp"
    android:layout_gravity="right"
    android:layout_marginRight="8dp"
    android:background="?selectableItemBackground"
    android:id="@+id/shareButton" />

<ImageButton
    android:src="@drawable/ic_tag"
    android:layout_width="48dp"
    android:layout_height="48dp"
    android:layout_gravity="right"
    android:layout_marginRight="8dp"
    android:background="?selectableItemBackground"
    android:id="@+id/tagButton" />

<ImageButton
    android:src="@drawable/ic_action_action_bookmark"
    android:layout_width="48dp"
    android:layout_height="48dp"
    android:layout_gravity="right"
    android:layout_marginRight="8dp"
    android:background="?selectableItemBackground"
    android:id="@+id/bookmarkButton" />

</android.support.v7.widget.Toolbar>

And in onCreate:

@Override
protected void onCreate(Bundle savedInstanceState) {

    super.onCreate(savedInstanceState);
    setContentView(R.layout.newsdetail_activity);
    mActionBarToolbar = (Toolbar) findViewById(R.id.toolbar);
    setSupportActionBar(mActionBarToolbar);
    ActionBar actionBar = getSupportActionBar();
    actionBar.setDisplayHomeAsUpEnabled(true);
    actionBar.setHomeButtonEnabled(true);
 }

And onOptionItemSelected:

@Override
public boolean onOptionsItemSelected(MenuItem item) {


    switch (item.getItemId()) {
        case android.R.id.home:
            onBackPressed();
            break;
        case R.id.shareButton:

            Log.d(TAG, "SHARE BUTTON");

            break;
    }
    return true;
}

The click on shareButton in toolbar is not firing. Can anyone tell the reason for this?

Answer 1

I ended up by using the following code

 ImageButton imageButton = (ImageButton) toolbar.findViewById(R.id.shareButton);

        imageButton.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {


            }
        });

I don't know if this the correct way.But it works