This transaction should be completed with a commit call

Question

I have this code to change fragment:

FragmentTransaction fragmentTransaction = getSupportFragmentManager()
            .beginTransaction()
            .replace(R.id.frame_content, fragment);

if (isBackable) fragmentTransaction.addToBackStack(null);
fragmentTransaction.commit();

Android studio warn:

This transaction should be completed with a commit() call

I don't know how the correct way to solve this warning.

Answer 1

It's a false positive.

Android Lint only sees you have chained some fragment transaction calls together without a commit but fails to see the commit on a later row.

You can either

1. ignore the warning,

2. suppress it with @SuppressLint("CommitTransaction"), or

3. remove the method chaining i.e. replace

   FragmentTransaction fragmentTransaction = getSupportFragmentManager()
               .beginTransaction()
               .replace(R.id.frame_content, fragment);
   

   with

   FragmentTransaction fragmentTransaction = getSupportFragmentManager()
               .beginTransaction();
   fragmentTransaction.replace(R.id.frame_content, fragment);