Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

The "unexpected ++" error in jslint [duplicate]

The longstanding best practice: Use i += 1 instead, following jslint's advice.

As for why it is a better practice than ++, according to Crockford:

The increment ++ and decrement -- operators make it possible to write in an extremely terse style. In languages such as C, they made it possible to write one-liners that: for (p = src, q = dest; !*p; p++, q++) *q = *p; Most of the buffer overrun bugs that created terrible security vulnerabilities were due to code like this. In my own practice, I observed that when I used ++ and --, my code tended to be too tight, too tricky, too cryptic. So, as a matter of discipline, I don’t use them any more.

Edit: Included comment from Nope as this answer continues to get views. Please continue to upvote his comment as well :)


Just add /*jslint plusplus: true */ in front of your javascript file.


To avoid confusion, and possible problems when using minifiers, always wrap parens around the operator and its operand when used together with the same (+ or -).

var i = 0, j = 0;
alert(i++ +j);

This adds i and j (and increments i as a side effect) resulting in 0 being alerted.

But what is someone comes along and moves the space?

var i = 0, j = 0;
alert(i+ ++j);

Now this first increments j, and then adds i to the new value of j, resulting in 1 being alerted.

This could easily be solved by doing

var i = 0, j = 0;
alert((i++) +j); 

Now this cannot be mistaken.


Personally, I prefer to put statements such as i++ on a line by themselves. Including them as part of a larger statement can cause confusion for those who aren't sure what the line's supposed to be doing.

For example, instead of:

value = func(i++ * 3);

I would do this:

value = func(i * 3);
i++;

It also means people don't have to remember how i++ and ++i work, and removes the need to apply quite so many preference rules.


The real problem of the ++ operator is that it is an operator with side effects and thus it is totally opposed to the principle of functional programming.

The "functional" way to implement i++ would be i = i + 1 where you explicitly reassign the variable with no side effects and then use it.

The possibility of confusion is that ++ does two things by adding a value AND reassigning it to the variable.


JSLint friendly loop

for (i = 0; i < 10; i += 1) {
    //Do somthing
}