Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

"take a picture and present it" in portrait mode on Samsung Galaxy S

I am trying to simply take a picture and present it in an ImageView with my samsung galaxy s. it's working fine when I do it on landscape but not on portrait. I am not getting any error or exception - just not getting anything... There is a lot of questions about this topic and it seems to be problematic (something about camera orientation) but counldn't figure out the final solution for a simple "take a picture and present it" code. here is my (problematic) code that doesn't work:

private void setUpListeners() {
    takePicture.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View arg0) {
            Intent cameraIntent = new Intent(
                    android.provider.MediaStore.ACTION_IMAGE_CAPTURE);
            startActivityForResult(cameraIntent, CAMERA_PIC_REQUEST);
        }
    });
}

protected void onActivityResult(int requestCode, int resultCode, Intent data) {
    super.onActivityResult(requestCode, resultCode, data);
    if (resultCode == RESULT_OK) {
        if (requestCode == CAMERA_PIC_REQUEST) {
            Log.d("onActivityResult", "CAMERA_PIC_REQUEST returned");
            dishImage = (Bitmap) data.getExtras().get("data");
            if (dishImage==null)
                Log.d("onActivityResult", "dishImage==null");
            imageView = (ImageView) findViewById(R.id.dishinfodishimageview);
            imageView.setImageBitmap(dishImage);
            imageView.setVisibility(View.VISIBLE);
            takePicture.setVisibility(View.GONE);
            (new UploadImage()).execute(null);
        }
    } else {
        Log.e("onActivityResult",
                "no able to presenting the picture of the dish");
    }

}

I just need a code that works (on any device) or a fix to my code... thx.

like image 615
yehudahs Avatar asked Sep 01 '12 12:09

yehudahs


2 Answers

The reason that onCreate() is called is because when you do call the camera activity during the portrait orientation, it will change the orientation and destroy your previous activity. After finishing the onActivityResult(), your activity will be re-created.

One solution to this problem is to set the manifest to ignore changes on orientation change, you can do it by using this:

<activity android:name=".MyMainActivity"
     android:configChanges="orientation"
     android:label="@string/app_name" />

If you are using API starts with level 13, you can consider screenSize for the configChanges manifest.

like image 66
dtheo Avatar answered Sep 27 '22 18:09

dtheo


I can only suggest a hack for this problem. Save your results in shared preferences in onActivityResult() and during onCreate load your content from shared preferences. I know this is a bad solution but this will keep you going until you find a better answer. And don't forget to clear your shared preferences once you are done, else your activity will always initialize with old data.

like image 40
ashutosh Avatar answered Sep 27 '22 18:09

ashutosh