Switch statement with returns -- code correctness [closed]

Question

Let's say I have code in C with approximately this structure:

switch (something) {     case 0:       return "blah";       break;      case 1:     case 4:       return "foo";       break;      case 2:     case 3:       return "bar";       break;      default:       return "foobar";       break; } 

Now obviously, the breaks are not necessary for the code to run correctly, but it sort of looks like bad practice if I don't put them there to me.

What do you think? Is it fine to remove them? Or would you keep them for increased "correctness"?

Answer 1

Remove the break statements. They aren't needed and perhaps some compilers will issue "Unreachable code" warnings.

Answer 2

I would take a different tack entirely. Don't RETURN in the middle of the method/function. Instead, just put the return value in a local variable and send it at the end.

Personally, I find the following to be more readable:

String result = "";  switch (something) { case 0:   result = "blah";   break; case 1:   result = "foo";   break; }  return result;