Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Stack Trace for logging in .NET

I've written a logger/exceptionfactory module, which uses System.Diagnostics.StackTrace, to get attributes from calling methods and their declaring types. However I noticed, that if I run the code outside of Visual Studio in Release mode, some of my shorter methods get inlined and missing from the stack trace. Now I have no way to test whether a method will get inlined in runtime, but I do not want to [MethodImpl(MethodImplOptions.NoInlining)] every important method. But if a method from my base classes will be missing because of it, I can misread the layer and operation information and that could lead to false log or misparameterized exceptions.

Is there a rule of thumb what gets inlined where and when? Are virtual methods, static methods, base class methods treated any differently? Do I only have to worry about inlining inside assembly? Inside namespace?

like image 489
TDaver Avatar asked Jan 31 '11 10:01

TDaver


1 Answers

Yes, there are some rules but they are heuristics used by the JIT compiler and these heuristics can change at a moment's notice.

  1. Virtual methods cannot be inlined.
  2. Interface methods, on the other hand, may be inlined although I am not 100% sure whether or not this would collapse the stack trace.
  3. Static methods and non-virtual instance methods can certainly be inlined.
  4. Inlining may cross namespaces (of course) and assemblies (not so obvious) because it happens at run-time, when the JIT compiles the method call.
  5. "Heavy" methods will not be inlined. This depends on the definition of "heavy", and is part of the heuristics the JIT applies.

Some of the heuristics for "heavy" that I'm aware of:

  • Methods which use exception handling (i.e. try-catch or try-finally blocks) are not inlined.
  • Methods with large code (~32 IL bytes but I may be remembering this wrong) are not inlined.
  • Methods with loops are not inlined (unless the loop can be completely unrolled or eliminated).
like image 195
Sasha Goldshtein Avatar answered Oct 09 '22 04:10

Sasha Goldshtein