SpringMVC servlet mapping

Question

I've written a really simple Spring MVC app. I apologise I'm rather new to Spring MVC so bear with me.

The web.xml is as follows

<?xml version="1.0" encoding="UTF-8"?>
<web-app version="2.5" xmlns="http://java.sun.com/xml/ns/javaee"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd">

    <!-- The definition of the Root Spring Container shared by all Servlets and Filters -->
    <context-param>
        <param-name>contextConfigLocation</param-name>
        <param-value>/WEB-INF/spring/root-context.xml</param-value>
    </context-param>

    <!-- Creates the Spring Container shared by all Servlets and Filters -->
    <listener>
        <listener-class>org.springframework.web.context.ContextLoaderListener</listener-class>
    </listener>

    <!-- Processes application requests -->
    <servlet>
        <servlet-name>appServlet</servlet-name>
        <servlet-class>org.springframework.web.servlet.DispatcherServlet</servlet-class>
        <init-param>
            <param-name>contextConfigLocation</param-name>
            <param-value>/WEB-INF/spring/appServlet/servlet-context.xml</param-value>
        </init-param>
        <load-on-startup>1</load-on-startup>
    </servlet>

    <servlet-mapping>
        <servlet-name>appServlet</servlet-name>
        <url-pattern>/</url-pattern>
    </servlet-mapping>

</web-app>

My first question is, I have a jsp page for login with the following code...

<form action="/login" method="post" >
Username : <input name="username" type="text" />
Password : <input name="password" type="password" />
<input type="submit" />
</form>

This gives a 404 but in my Controller, I've mapped the controller to /login with the code below...

@Controller
public class LoginController {

    private static final Logger logger = LoggerFactory.getLogger(LoginController.class);

    /**
     * Simply selects the home view to render by returning its name.
     */
    @RequestMapping(value = "/login", method = RequestMethod.POST)
    public String home(Locale locale, Model model, String username, String password) {

        if(username.equalsIgnoreCase("david"))
        {
            logger.info("Welcome home! the client locale is "+ locale.toString());

            Date date = new Date();
            DateFormat dateFormat = DateFormat.getDateTimeInstance(DateFormat.LONG, DateFormat.LONG, locale);

            String formattedDate = dateFormat.format(date);

            model.addAttribute("serverTime", formattedDate );

            return "home";
        }
        else
        {
            return "void";
        }

    }

}

My understanding is the @requestmapping should do the servlet mapping rather than in the web.xml, is this correct? The value of /WEB-INF/spring/appServlet/servlet-context.xml is shown below also if needed.

<?xml version="1.0" encoding="UTF-8"?>
<beans:beans xmlns="http://www.springframework.org/schema/mvc"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xmlns:beans="http://www.springframework.org/schema/beans"
    xmlns:context="http://www.springframework.org/schema/context"
    xsi:schemaLocation="http://www.springframework.org/schema/mvc http://www.springframework.org/schema/mvc/spring-mvc-3.0.xsd
        http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-3.0.xsd
        http://www.springframework.org/schema/context http://www.springframework.org/schema/context/spring-context-3.0.xsd">

    <!-- DispatcherServlet Context: defines this servlet's request-processing infrastructure -->

    <!-- Enables the Spring MVC @Controller programming model -->
    <annotation-driven />

    <!-- Handles HTTP GET requests for /resources/** by efficiently serving up static resources in the ${webappRoot}/resources directory -->
    <resources mapping="/resources/**" location="/resources/" />

    <!-- Resolves views selected for rendering by @Controllers to .jsp resources in the /WEB-INF/views directory -->
    <beans:bean class="org.springframework.web.servlet.view.InternalResourceViewResolver">
        <beans:property name="prefix" value="/WEB-INF/views/" />
        <beans:property name="suffix" value=".jsp" />
    </beans:bean>

    <context:component-scan base-package="org.david.myapp" />



</beans:beans>

So my first question is : is the servlet mapping done in the web.xml or at the @requestmapping in the controller class?

Second question : what's the best way to architect this to have more pages, should I keep appending to the webxml? Should I create a controller for every url? Should I create a servlet-context for every url?

Thanks for reading :)

Answer 1

You have defined <url-pattern> to be /, which means that your appServlet will only receive requests to the root url. By changing it to /* the appServlet will get all incoming requests. This will work, but you can also consider to create a specific loginServlet which could be mapped to url /login/*.

1. You can have multiple servlets defined in a single web.xml. Which request will hit each servlet is specified by adding more <servlet-mapping> tags.
2. A servlet may have many controllers. Typically, one controller serves a specific part of your domain, e.g. PersonController, AddressController, etc.
3. Each controller usually handles several urls that are logically grouped together, e.g. /persons/{id}, /persons/search, /persons/add, etc.