Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Size of ShareAction icon issue on ActionBar with ShareActionProvider-v7

I was working around my old ShareAction on my ActionBar and it was working since I updated my Packages on SDK Manager. I saw this doc from Google which says,

To add a "share" action to your activity, put a ShareActionProvider in the app bar's menu resource. For example:

And I've added the same without adding any Icons:

<item android:id="@+id/action_share"
   android:title="@string/share"
   app:showAsAction="ifRoom"
   app:actionProviderClass="android.support.v7.widget.ShareActionProvider"/>

I was using:

app:actionProviderClass="Mypackagename.ShareActionProvider"

With a custom ShareActionProvider with the following code.you can see it here.

I saw a hack or a trick to do that (with ShareActionProvider-v4) and everything was good since I decided to use android.support.v7.widget.ShareActionProvider.

So, Here is my currently code:

<item
   android:id="@+id/shareac"
   android:title="@string/share"
   app:actionProviderClass="android.support.v7.widget.ShareActionProvider"
   app:showAsAction="always" />

I didn't use the Icon because here the doc says,

You do not need to specify an icon, since the ShareActionProvider widget takes care of its own appearance and behavior. However, you do need to specify a title with android:title, in case the action ends up in the overflow menu.

And here is what I've done so far:

 @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        getMenuInflater().inflate(R.menu.menu_main_details, menu);
        // Locate MenuItem with ShareActionProvider
        MenuItem item = menu.findItem(R.id.shareac);
        // Fetch and store ShareActionProvider
        mShareActionProvider = (ShareActionProvider) MenuItemCompat.getActionProvider(item);
        Intent shareIntent = new Intent();
        shareIntent.setAction(Intent.ACTION_SEND);
        Bundle extra = getIntent().getExtras();
        String title = extra.getString("title");
        Bundle extraurl = getIntent().getExtras();
        String url = extraurl.getString("url");
        shareIntent.putExtra(Intent.EXTRA_TEXT, "Check this new project from something : " + title + url);
        shareIntent.setType("text/plain");
        mShareActionProvider.setShareIntent(shareIntent);
        return true;
    }

So, here what I see right now in Android Studio 1.5.1 Is,

enter image description here

And if run and compile the app:

enter image description here

As you can see, the size of ShareAction is too much. (It's violating the MaterialDesign guideline I guess).


I forgot to say, I've already tried android:icon="@mipmap/ic_share" which that was working with my previous method/trick. But, check this Preview from AndroidStudio:

enter image description here

And here is after compiled:

enter image description here

Nothing changed!

So, my question: is that a bug or what am I doing wrong here?

Intent.createChooser didn't work also: from: https://stackoverflow.com/a/34797718/4409113

Edit:

The most interesting part, i just saw the same design and the same resutls from Google on the following course and on that app which they've called it SunShine app:

Applink

Course:

https://www.udacity.com//course/viewer#!/c-ud855/l-3961788738/m-4294896397

like image 778
ʍѳђઽ૯ท Avatar asked Jan 25 '16 14:01

ʍѳђઽ૯ท


2 Answers

Okay, As ianhanniballake at this post said,

Icons in material design are 24dp x 24dp, as properly reflected by the SearchView. However, ShareActionProvider has not yet been updated to material design by default.

By the way, i've just posted a question/report to code.google.com which you can see it here:

http://code.google.com/p/android/issues/detail?id=200335

It seems that default icon is 24dp x 24dp but it should be like this:

enter image description here

But now, it is like this:

enter image description here

Seems to be a bug and still waiting for accepting or answering about it.I'll update this post if they answered.7 days passed!

UPDATE:

Finally, they've assigned the defect on to the development team and they will update this issue with more information as it becomes available.

Big thanks to [email protected] at Google for support.

The answer is available here: http://code.google.com/p/android/issues/detail?id=200335#c10

I will update this answer if any updates or any fixes was available.

UPDATE: http://code.google.com/p/android/issues/detail?id=200335#c12

Hi, The development team has fixed the issue that you have reported and it will be available in a future build. Thanks

like image 164
ʍѳђઽ૯ท Avatar answered Oct 16 '22 19:10

ʍѳђઽ૯ท


Icons in material design are 24dp x 24dp, as properly reflected by the SearchView. However, ShareActionProvider has not yet been updated to material design by default.

You can set actionModeShareDrawable in your theme to set the share icon in the ShareActionProvider:

<item name="actionModeShareDrawable">@drawable/share_icon</item>

Note that ShareActionProvider is not found anywhere in the material design guidelines and with Android M's Direct Share capability (which requires you use a standard share intent at this time), it is unclear on whether the ShareActionProvider is a suggested pattern any more.

For more detail Visit Here.

AppCompat ShareActionProvider icon is too big compared to other icons

like image 2
Harshad Avatar answered Oct 16 '22 18:10

Harshad