Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Singleton Properties

Ok, if I create a singleton class and expose the singleton object through a public static property...I understand that.

But my singleton class has other properties in it. Should those be static? Should those also be private?

I just want to be able to access all properties of my singleton class by doing this:

MySingletonClass.SingletonProperty.SomeProperty2

Where SingletonProperty returns me the single singleton instance. I guess my question is, how do you expose the other properties in the singleton class..make them private and then access them through your public singleton static property?

Or should all your other properties and methods of a singleton be public non-static?

like image 215
PositiveGuy Avatar asked Mar 08 '10 21:03

PositiveGuy


4 Answers

Once you get the SingletonProperty (which is the single instance of an Object), anything after that can be implemented as if you were creating a class to be instanciated because the Singleton is really a single instance of a regular Object.

For example, the following Singleton (obviously not the best Singleton design, but bear with me) offers up two public Properties called Value and Name:

public class MySingleton
{
    private static MySingleton _instance;    

    private MySingleton() { }

    public static MySingleton Instance
    {
        get
        {
            if(_instance == null)
                _instance = new MySingleton();

            return _instance;
        }
    }

    // Your properties can then be whatever you want
    public string Value { get; set; }

    public string Name { get; set; }
}

Accessing these properties would look like:

MySingleton.Instance.Name = "StackOverflow";

MySingleton.Instance.Value = "Rocks!";
like image 130
Justin Niessner Avatar answered Nov 18 '22 19:11

Justin Niessner


Make them public properties as you would any other class. Using the singleton pattern would be independent of this.

like image 44
hunter Avatar answered Nov 18 '22 20:11

hunter


So long as they're not static, you need an object instance to access the property. And if the only way to create the object instance is via the singleton pattern, your class properties are inherently part of the single class instance. Nothing special is required.

like image 2
Andrew Avatar answered Nov 18 '22 20:11

Andrew


No, let them be public. Since there can be only one instance of the class, the only way to access those properties will be through the single instance.

like image 2
Thomas Levesque Avatar answered Nov 18 '22 20:11

Thomas Levesque