Showing Morning, afternoon, evening, night message based on Time in java

Question

What i am trying to do::

Show message based on

• Good morning (12am-12pm)
• Good after noon (12pm -4pm)
• Good evening (4pm to 9pm)
• Good night ( 9pm to 6am)

---

CODE::

I used 24-hr format to get this logic

private void getTimeFromAndroid() {         Date dt = new Date();         int hours = dt.getHours();         int min = dt.getMinutes();          if(hours>=1 || hours<=12){             Toast.makeText(this, "Good Morning", Toast.LENGTH_SHORT).show();         }else if(hours>=12 || hours<=16){             Toast.makeText(this, "Good Afternoon", Toast.LENGTH_SHORT).show();         }else if(hours>=16 || hours<=21){             Toast.makeText(this, "Good Evening", Toast.LENGTH_SHORT).show();         }else if(hours>=21 || hours<=24){             Toast.makeText(this, "Good Night", Toast.LENGTH_SHORT).show();         }     } 

---

Question:

• Is this this best way of doing it, If no which is the best way

Answer 1

You should be doing something like:

Calendar c = Calendar.getInstance(); int timeOfDay = c.get(Calendar.HOUR_OF_DAY);  if(timeOfDay >= 0 && timeOfDay < 12){     Toast.makeText(this, "Good Morning", Toast.LENGTH_SHORT).show();         }else if(timeOfDay >= 12 && timeOfDay < 16){     Toast.makeText(this, "Good Afternoon", Toast.LENGTH_SHORT).show(); }else if(timeOfDay >= 16 && timeOfDay < 21){     Toast.makeText(this, "Good Evening", Toast.LENGTH_SHORT).show(); }else if(timeOfDay >= 21 && timeOfDay < 24){     Toast.makeText(this, "Good Night", Toast.LENGTH_SHORT).show(); } 

Answer 2

For anyone who is looking for the latest Kotlin syntax for @SMA's answer, here is the helper function :

fun getGreetingMessage():String{     val c = Calendar.getInstance()     val timeOfDay = c.get(Calendar.HOUR_OF_DAY)      return when (timeOfDay) {            in 0..11 -> "Good Morning"            in 12..15 -> "Good Afternoon"            in 16..20 -> "Good Evening"            in 21..23 -> "Good Night"            else -> "Hello"       }     }