Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

should minified files be committed into source control?

I come from a C# background and have moved into Javascript development. In the C# world, I would never consider committing an executable (.DLL, .EXE) into source control because you cannot verify that the executable matches the code. However I see plenty of examples of github repositories that contain a .js next to a .min.js file and I see it as a similar smell.

Is it helpful to third parties using your library or should any minifying be handled by them - such as in the use case that a library is developed in coffeescript. Are there any best practices here?

like image 696
Mr Wilde Avatar asked Oct 24 '13 12:10

Mr Wilde


2 Answers

Minified files should not be under source control for the simple reason that they are not 'source' files. If you need to fix a bug in your javascript you don't do it in the minified file so why have it under source control.

like image 184
Chris Avatar answered Oct 13 '22 01:10

Chris


If your repository shippes a way to minify, don't add it. So if you are writing a minifier for js code, you don't have to submit the minified versions of your js code, as each person who clones or forks your repo should be able to generate their own minified files.

If your repo does not include a program/script/whatever to minify the js files, include them.

Disclaimer: This is my opinion and seems to be the most logical answer on this question for me!

like image 25
musicmatze Avatar answered Oct 13 '22 00:10

musicmatze