Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

setText(getString(R.strings.whatever) or setText(R.strings.whatever)?

Tags:

android

Both work, obviously if you start concatenating you'll need get string in order to avoid displaying an int.

Question: which is the most 'elegant' or 'recommended' to use?

Thank you

like image 796
Stephan Tual Avatar asked Apr 12 '12 09:04

Stephan Tual


1 Answers

The second approach is more elegant, since internally, the TextView (or whatever View-class) will do the job of getting the String for your specified resource.

Letting components do the internal work is always preferred. Also, it is shorter and more readable.


About the internals I talked about: If you have a look at Androids source-code, you can see that the setText(int)-method of TextView is implemented like this:

public final void setText(int resid) {
  setText(getContext().getResources().getText(resid));
}

So, it internally uses the Context-class to get the string from the resource-id. Now, if you look at the getText()-method (which also comes from the Context-class), you can see that it is implemented the same way:

public final String getString(int resId) {
  return getResources().getString(resId);
}

So for performance or reliability reasons, it makes no difference. Still, it is shorter and more readable.

like image 79
Lukas Knuth Avatar answered Oct 21 '22 21:10

Lukas Knuth