Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

ServiceWorker 'fetch' event not triggered for favicons

I am using service worker for caching contents in my site (https://adhiyan.in). Serviceworker is getting installed and activated properly. In the 'fetch' event handler, I am serving contents from cache if available. If contents are not available in cache, I am fetching the content and updating the cache with the same. It is able to serve assets and cache new assets on demand.

importScripts('/assets/js/serviceworker-cache-polyfill.js');

var CACHE_NAME = 'adhiyan-cache-v1';
var urlsToCache = [
  '/',
  '/assets/css/app.min.css',
  '/assets/js/app.min.js'
];

self.addEventListener('install', function(event) {
  // Perform install steps
  event.waitUntil(
    caches.open(CACHE_NAME)
    .then(function(cache) {
      console.log('Opened cache');
      return cache.addAll(urlsToCache);
    })
  );
});

self.addEventListener('fetch', function(event) {
  event.respondWith(
    caches.match(event.request)
    .then(function(response) {
      // Cache hit - return response
      if (response) {
        console.log("Cache hit for '" + event.request.url + "'- return response");
        return response;
      }

      console.log("Cache miss for '" + event.request.url + "'");

      // IMPORTANT: Clone the request. A request is a stream and
      // can only be consumed once. Since we are consuming this
      // once by cache and once by the browser for fetch, we need
      // to clone the response
      var fetchRequest = event.request.clone();

      return fetch(fetchRequest).then(
        function(response) {
          // Check if we received a valid response
          if (!response || response.status !== 200 || response.type !== 'basic') {
            console.log("Invalid response for '" + event.request.url + "'");
            return response;
          }

          // Cache only '/assets'
          if (event.request.url.indexOf('/assets') == -1) {
            console.log("Not an asset '" + event.request.url + "'");
            return response;
          }

          // IMPORTANT: Clone the response. A response is a stream
          // and because we want the browser to consume the response
          // as well as the cache consuming the response, we need
          // to clone it so we have 2 stream.
          var responseToCache = response.clone();
          console.log("Updating cache for '" + event.request.url + "'");
          caches.open(CACHE_NAME)
            .then(function(cache) {
              cache.put(event.request, responseToCache);
            });

          return response;
        }
      );
    })
  );
});

However, I see that browser is downloading favicons without triggering 'fetch' event. I can confirm the behavior from the network panel of Chrome devtools. Can someone help me understand this behavior? Am I missing out something in the code?

Network panel Chrome devtools

like image 684
Varunkumar Nagarajan Avatar asked Aug 17 '15 17:08

Varunkumar Nagarajan


1 Answers

This is a bug in Chrome: https://code.google.com/p/chromium/issues/detail?id=448427

It should allow service workers to intercept the request.

like image 163
Matt Gaunt Avatar answered Nov 14 '22 07:11

Matt Gaunt