Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

ScrollView content not filling in SwiftUI

I have a scrollview which content is a VStack containing a ForEach loop to create some Rows instead of a list. A List has some downsides like the dividers.

My Issue is that the Row is not filling the scrollview. I think the scrollview width is not filling the screen.

NavigationView {
        Toggle(isOn: $onlineStatus) {
            Text("Online Only")
        }.padding([.leading, .trailing], 15)

        ScrollView {
            VStack(alignment: .trailing) {
                ForEach(onlineStatus ? self.notes.filter { $0.dot == .green } : self.notes) { note in
                    NavigationButton(destination: Text("LOL")) {
                        CardRow(note: note)
                            .foregroundColor(.primary)
                            .cornerRadius(8)
                            .shadow(color: .gray, radius: 3, x: 0, y: -0.01)
                    }.padding([.leading, .trailing, .top], 5)
                }.animation(self.onlineStatus ? .fluidSpring() : nil)
            }
        }.padding([.leading, .trailing])

        .navigationBarTitle(Text("Your documents"))
    }

This is giving me this result:

enter image description here

That's my CardRow:

struct CardRow: View {
var note: Note

var body: some View {
    HStack {
        Image(uiImage: UIImage(named: "writing.png")!)
            .padding(.leading, 10)

        VStack(alignment: .leading) {
            Group {
                Text(note.message)
                    .font(.headline)
                Text(note.date)
                    .font(.subheadline)
            }
            .foregroundColor(.black)
        }

        Spacer()
        VStack(alignment: .trailing) {
            Circle().foregroundColor(note.dot)
                .frame(width: 7, height: 7)
                .shadow(radius: 1)
                .padding(.trailing, 5)
            Spacer()
        }.padding(.top, 5)
    }
    .frame(height: 60)
    .background(Color(red: 237/255, green: 239/255, blue: 241/255))
}

}

like image 535
SwiftiSwift Avatar asked Jun 09 '19 11:06

SwiftiSwift


3 Answers

Use .frame(minWidth: 0, maxWidth: .infinity) on the RowView or inside of it

like image 50
DenFav Avatar answered Nov 06 '22 03:11

DenFav


Try setting the frame width of the RowView to UIScreen.main.bounds.width: .frame(width: UIScreen.main.bounds.width)

like image 45
nextsft Avatar answered Nov 06 '22 01:11

nextsft


Best solution I found is to use GeometryReader to fill the ScrollView's contents to the outer view's width. And be sure to use a Spacer() in each row's HStack. This handles safe areas and rotation well.

struct Card : View {
    var body: some View {
        HStack {
            VStack(alignment: .leading) {
                Text("Header")
                    .font(.headline)
                Text("Description")
                    .font(.body)
            }
            Spacer()
        }
            .padding()
            .background(Color.white)
            .cornerRadius(8)
            .shadow(color: Color.black.opacity(0.15), radius: 8, x: 0, y: 0)
    }
}

struct Home : View {
    var body: some View {
        GeometryReader { geometry in
            NavigationView {
                ScrollView {
                    VStack(alignment: .leading, spacing: 16) {
                        Card()
                        Card()
                        Card()
                    }
                        .padding()
                        .frame(width: geometry.size.width)
                }
                    .navigationBarTitle(Text("Home"))
            }
        }
    }
}

See resulting screenshot:

enter image description here

like image 5
Ryan Ashcraft Avatar answered Nov 06 '22 01:11

Ryan Ashcraft