Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Ruby, stack level too deep (SystemStackError)

Tags:

ruby

I have the following code:

class BookPrice
  attr_accessor :price
  def initialize(price)
    @price = price
  end

  def price_in_cents
    Integer(price*100 + 0.5)
  end
end

b = BookPrice.new(2.20)
puts b.price_in_cents

This all works well and produces 220. But when I replace the second line attr_accessor :price with:

def price
  @price = price
end

I get stack level too deep (SystemStackError) error. What's going on? I know I can replace Integer(price*100 + 0.5) with @price instead of the method call price, but I want to keep it the way it is for OOP reasons. How can I make this code work the way it is without attr_accessor?

like image 594
daremkd Avatar asked Sep 29 '13 20:09

daremkd


2 Answers

Your below code

def price   @price = price # <~~ method name you just defined with `def` keyword. end 

Creates never stopable recursion,.

How can I make this code work the way it is without attr_accessor?

You need to write as

def price=(price)   @price = price end def price   @price  end 
like image 145
Arup Rakshit Avatar answered Oct 04 '22 19:10

Arup Rakshit


You need to do:

@price = self.price

to differentiate between your object attribute price and your method parameter price.

like image 38
Translunar Avatar answered Oct 04 '22 19:10

Translunar