Ruby on Rails - after_validation if valid?

Question

Right now, from what I know, after_validation will be called even if the model fails the validations. Is there a way to only call it if the model is valid? I tried adding return false unless self.valid? in the after_validation method but that triggers validation again and it creates an infinite loop.

Answer 1

The failing validations add to the errors for the record, so you could just check:

return false unless self.errors.empty?

Answer 2

Have you thought about using the before_save callback instead?

I believe that will only be called if the object is valid.

Answer 3

I know this is an old question but I ran into the same error when using a custom validation on a model I had created. Looking at the docs there's a part covering custom methods and it states that such validations are called each time the .valid? method. That's probably why the infinite loop got triggered when the :after_validation callback was triggered.