Return from context above

Question

This question is little complicated to formulate but I will do my best. Trough our code we have snippets such as

response = do_something()
return response unless response.ok?

I was think of writing wrapper method which would remove need for this step, and it would look something like this

def rr(&block)
  response = yield
  unless response.ok?
    # somehow do return but in context above (magic needed here)
  end
  response
end

After that I would be able to minimize code from above to be

response = rr { do_something() }

Seems impossible but this is Ruby so maybe there is a way?

Answer 1

The correct way to return across multiple layers of the stack when something goes wrong (which appears to be what you are trying to do) is to raise an exception:

class RequestFailedException < StandardError; end

def rr(&block)
  response = yield
  unless response.ok?
    raise RequestFailedException, "Response not okay: #{response.inspect}"
  end
  response
end

Usage:

def do_lots_of_things()
  rr { do_something }
  rr { do_something_else }
  rr { another_thing }
end

begin
  do_lots_of_things
rescue RequestFailedException => e
  # Handle or ignore error
end