Remove the last 2 characters from a string in Ruby?

Question

I'm collecting all my user's email addresses for a mass mailing like this:

def self.all_email_addresses
  output = ''
  User.all.each{|u| output += u.email + ", " }
      output
end

However, I end up with an extra ", " on the string of email addresses.

How can I get rid of this / is there a better way to get a comma separated list of email addresses?

Answer 1

remove the last two characters

str.chop.chop # ...or...
str[0..-3]

Although this does answer the exact question, I agree that it isn't the best way to solve the problem.

Answer 2

Use join:

def self.all_email_addresses
  User.all.collect {|u| u.email}.join ', '
end