Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Remove max (or min) from collection using Java8 streaming API

I have little problem with code design that use new streaming API from Java 8. I would like to learn new things and one of the task is:

Reject max and min from list. List not contains duplicates.

Looks simple? Nope... My code:

  List<Integer> ranges = Lists.newArrayList(new Range(1, 15));
        List<Integer> collect = ranges.stream()
                .filter(x -> x != ranges.stream()
                        .mapToInt(Integer::intValue)
                        .max()
                        .getAsInt())
                .filter(x -> x != ranges.stream()
                        .mapToInt(Integer::intValue)
                        .min()
                        .getAsInt())

                .collect(Collectors.toList());
        assertThat(collect).hasSize(13);   // OK
        assertThat(collect).isEqualTo(Lists.newArrayList(new Range(2,14)));   // OK

this code is good (if only we dont have duplicates of min/max, but this is not a core problem here) but problem is that I use here three streams. First is main stream, second to remove max and third to remove min. Is there any possibility to do this task in one stream?

//edit: Very primitive Scala version:

val list = List.range(1, 15).sortWith(_>_).tail.reverse.tail

with additional sort because we could have shuiffeled list.

like image 839
Koziołek Avatar asked Apr 07 '14 11:04

Koziołek


1 Answers

Don't forget Collection.removeIf. You can compute min and max, and then do:

list.removeIf(x -> x == min || x == max);

(This also deals well with duplicates.)

like image 52
Brian Goetz Avatar answered Sep 24 '22 19:09

Brian Goetz