One OnClickHandler for multiple Buttons

Question

I find myself doing things like this all the time:

    Button button1 = (Button) findViewById(R.id.button1);     Button button2 = (Button) findViewById(R.id.button2);     Button button3 = (Button) findViewById(R.id.button3);      button1.setOnClickListener(menuButtonListener);     button2.setOnClickListener(menuButtonListener);     button3.setOnClickListener(menuButtonListener); ... 

and

   private OnClickListener myButtonListener = new OnClickListener() {         @Override         public void onClick(View v) {       switch(v.getId()){        case R.id.button1 :     ... 

Is there a better way to set the OnClickListener?

Answer 1

You can also set it in your layout xml using the android:onclick attribute.

android:onClick="onClick" 

Then in your activity class add the onClick method.

public void onClick(View v) { ... 

Here's the documentation.

Answer 2

Have your class implement `View.OnClickListener', like

public class MyActivity extends Activity implements View.OnClickListener {      Button button1, button2, button3;      @Override     public void onCreate(Bundle bundle) {         super.onCreate();          ...          button1 = (Button) findViewById(R.id.button1);         button2 = (Button) findViewById(R.id.button2);         button3 = (Button) findViewById(R.id.button3);          button1.setOnClickListener(this);         button2.setOnClickListener(this);         button3.setOnClickListener(this);    }     @Override    public void onClick(View v) {        switch(v.getId()) {            case R.id.button1:            // do stuff;            break;            case R.id.button2:            // do stuff;            break;        ...    } }