Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

NSString copy not copying?

  NSString *myString = @"sample string";
  NSString *newString = [myString copy];

If I set a breakpoint after these two lines, the pointer for myString is the same as the pointer for newString.

WTF? Isn't NSString copy supposed to return a pointer to a new object? Or am I missing something fundamental about how copy is supposed to work?

like image 409
Scotty Allen Avatar asked Mar 26 '10 06:03

Scotty Allen


4 Answers

Since NSString is not mutable it might just internally increase ref count and be done with it.

When you release one of those NSStrings it might just decrement ref count - standard memory management.

Do you see any issues with that?

like image 159
stefanB Avatar answered Dec 28 '22 23:12

stefanB


You can Allocate new variable like in sample

NSString *anotherString = [[NSString alloc] initWithString:originalString];
like image 28
R00We Avatar answered Dec 28 '22 22:12

R00We


Think about this: NSMutableString is a subclass of NSString. When your property is declared as NSString, you don't expect it to change.

Consider, if you used retain and someone gave you an NSMutableString and then later on does change it, your class will be broken.

However, you may think that always copying is slow. So NSString's copy simply calls retain. NSMutableString's copy makes an actual copy.

It is usually better to give spit out an NSString * because people won't have to copy it all the time.

like image 23
kizzx2 Avatar answered Dec 28 '22 23:12

kizzx2


It's a better practice to do copy the string value returned by a method, since the returned value maybe a mutable string object, and this value can be modified in other thread after returned by that method.

like image 37
SmallTitan Avatar answered Dec 29 '22 00:12

SmallTitan