Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Ninject.MVC3 Bootstrapper's Kernel property is marked as Obsolete. How can I get access to the kernel?

I updated Ninject.MVC3 package from 2.2.1.0 to 2.2.2.0. Before I had access to the Kernel object through BootStrapper.Kernel property but in the new version Kernel property is marked as obsolete. I get a warning saying

'Public ReadOnly Property Kernel As Ninject.IKernel' is obsolete: 'Do not use Ninject as Service Locator'.

Is there a different way to access the kernel in the new version?

like image 921
mahichR Avatar asked May 18 '11 15:05

mahichR


3 Answers

If you have a class that (for some reason) needs to retrieve objects from the Ninject kernel, you can include the kernel as one of the injected properties/constructor parameters on the class. This pattern is better in the sense that you're explicitly declaring that a particular class is using the kernel, rather than always having it available as the service locator pattern does.

This assumes that Ninject automatically adds an instance binding of the kernel to itself. I know that it used to do this, but if it doesn't you can add the binding manually.

like image 160
John Bledsoe Avatar answered Nov 12 '22 18:11

John Bledsoe


The reason why this has been marked Obsolete and will be changed to internal in future is that people tend to use Ninject as a service locator if it is possible to do so. But Service Locator is an antipattern that should not be used. And as we don't want to provide functionality that helps building badly designed software it will be removed in future.

If this needs a lot of changes in your code this is sign that your code is suffering from this malaise Dependency Injection wise and you really should change it to a better design.

  1. Limit your access to the kernel to a mimimum. There is almost no situation in MVC where you need something other than plain constructor injection. Therefore my first advice is to refactor to constructor injection where possible.
  2. For these very rare cases where you need access to the kernel to create other objects you should inject a factory to the class that needs the new instance and inject the kernel into this factory (if the Constructor has a Kernel parameter, it'll receive the instance doing the injecting).

If you really want to stay with service locator even if almost everyone will tell you not to, you will have to keep a static reference yourself.

like image 43
Remo Gloor Avatar answered Nov 12 '22 18:11

Remo Gloor


In ASP.NET MVC 3, I think DepedencyResolver is a clean way to get a service locator.

like image 2
Guillaume86 Avatar answered Nov 12 '22 19:11

Guillaume86