Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

.NET Core: Finally block not called on unhandled exception on Linux

I have created the following C# program:

namespace dispose_test
{
    class Program
    {
        static void Main(string[] args)
        {
            using (var disp = new MyDisposable())
            {
                throw new Exception("Boom");
            }
        }
    }

    public class MyDisposable : IDisposable
    {
        public void Dispose()
        {
            Console.WriteLine("Disposed");
        }
    }
}

When I run this using dotnet run, I see the following behavior:

  • Windows: Exception text written to console, "Disposed" printed ~20 second later, program exits.
  • Linux: Exception text written to console, program exits immediately. "Disposed" never written.

The delay on Windows is annoying, but the fact that Dispose() isn't called at all on Linux is troubling. Is this expected behavior?

EDITS Clarifications/additions from the conversation below:

  • This is not specific to using/Dispose(), which is just a special case of try/finally. The behavior also occurs generally with try/finally - the finally block is not run. I have updated the title to reflect this.
  • I have also checked for the execution of Dispose() by writing a file to the filesystem, just to ensure that problem wasn't related to stdout being disconnected from the console before Dispose() is run in the case of an unhandled exception. Behavior was the same.
  • Dispose() does get called if the exception is caught anywhere within the application. It's when it goes completely unhandled by the application that this behavior occurs.
  • On Windows, the long gap is not due to compilation delay. I started timing when the exception text was written to the console.
  • My original experiment was doing dotnet run on both platforms, which means separate compilations, but I have also tried by doing dotnet publish on Windows and directly running the output on both platforms, with the same result. The only difference is that, when run directly on Linux, the text "Aborted (core dumped)" is written after the exception text.

Version details:

  • dotnet --version -> 1.0.4.
  • Compiling to netcoreapp1.1, running on .NET Core 1.1.
  • lsb-release -d -> Ubuntu 16.04.1 LTS
like image 293
nlawalker Avatar asked May 17 '17 19:05

nlawalker


People also ask

Does finally execute after unhandled exception?

As you have not use Catch block it throw unhandled exception to the process level so any statement after finally block will not execute.

Will finally block gets executed after exception C#?

A finally block always executes, regardless of whether an exception is thrown.

Does try finally throw exception?

Yes, it absolutely will. Assuming your finally block doesn't throw an exception, of course, in which case that will effectively "replace" the one that was originally thrown.

What is try catch finally in C#?

catch − A program catches an exception with an exception handler at the place in a program where you want to handle the problem. The catch keyword indicates the catching of an exception. finally − The finally block is used to execute a given set of statements, whether an exception is thrown or not thrown.


1 Answers

Official response is that this is an expected behavior.

Interestingly enough, the C# doc page on try-finally explicitly calls this out right at the top (emphasis mine)

Within a handled exception, the associated finally block is guaranteed to be run. However, if the exception is unhandled, execution of the finally block is dependent on how the exception unwind operation is triggered. That, in turn, is dependent on how your computer is set up. For more information, see Unhandled Exception Processing in the CLR.

Usually, when an unhandled exception ends an application, whether or not the finally block is run is not important. However, if you have statements in a finally block that must be run even in that situation, one solution is to add a catch block to the try-finally statement. Alternatively, you can catch the exception that might be thrown in the try block of a try-finally statement higher up the call stack. That is, you can catch the exception in the method that calls the method that contains the try-finally statement, or in the method that calls that method, or in any method in the call stack. If the exception is not caught, execution of the finally block depends on whether the operating system chooses to trigger an exception unwind operation.

One thing I found in my experimentation is that it doesn't appear to be enough to catch the exception, you have to handle it as well. If execution leaves the catch block via a throw, the finally will not run.

like image 127
nlawalker Avatar answered Sep 21 '22 01:09

nlawalker