Moment.js isBefore function not working as expected

Question

My console log is giving me an unexpected output.

var bool = (moment("2017-04-08 23:00:00").isBefore(moment("2017-04-09 01:00:00", 'day')));
console.log(bool);

The output is false, for some reason. According to the documentation, the following code should return true.

moment('2010-10-20').isBefore('2011-01-01', 'year')

Even if it's not a full year past, if it's a different year, my understanding is that it should return false. In my case, while it hasn't yet been 24 hours, it is a different day. Is there something I'm not understanding correctly?

Answer 1

@Oliver Charlesworth is right, moment() doesn't accept 'day' as a second argument. Have a look here and scroll down for all its valid signatures.

---

With that being said, you can either convert

isBefore(moment("2017-04-09 01:00:00", 'day'));

to

isBefore(moment('2017-04-09 01:00:00'), 'day');

or to

isBefore('2017-04-09 01:00:00', 'day');

Both work.

---

Here is the signature for isBefore.