Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Modifying NSTextStorage attributes causes scroll view to jump around

I have implemented basic syntax highlighting by properly setting the NSTextStorage delegate of my NSTextView and changing the text attributes in -textStorageDidProcessEditing.

The basic process is as follows

- (void)textStorageDidProcessEditing:(NSNotification *)notification {
  NSTextStorage *storage = [notification object];
  [storage beginEditing];

  NSString *text = [storage string];
  NSRange textRange = NSMakeRange(0, [text length]);

  [storage removeAttribute:NSForegroundColorAttributeName range:textRange];

  // Some regex matching here ...

  [storage addAttribute:NSForegroundColorAttributeName
                  value:[COSyntax colorForPatternGroup:pattern.groupName]
                  range:capturedRanges[group]];

  [storage endEditing];
}

Whenever -removeAttribute:range: or -addAttribute:value:range is invoked when a SPACE character is entered, the NSTextViews surrounding NSScrollView location begins to jump around (scroll knob goes to some random position near the )

What's causing this?

like image 878
Era Avatar asked Mar 16 '11 10:03

Era


2 Answers

I have finally found out from my observations that the jumping happens not only when pressing spacebar but for other keys such as backspace as well and this happens exactly when both of these happen.
- Non-contiguous layout is turned on
- Any modification, even to attributes, of text preceding the visible region is made inside -textStorageDidProcessEditing:
Looks like it is a bug in Non-contiguous layout feature! Would be good if an expert could confirm.
It appears to have nothing to do with calling -beginEditing and -endEditing.

like image 81
trss Avatar answered Sep 21 '22 03:09

trss


Eric. I don't know if you solved this. However, I ran into a similar problem and I found out that turning off "Non-contiguous layout" option in the XCode 4.x attributes inspector for the NSTextView in case will solve the problem. The documentation for NSLayoutManager provides more clues (under "Overview" section): "Noncontiguous layout is an optional layout manager behavior new in Mac OS X v10.5...".

Here's the post

In my case, I experienced this behavior irrespective of using delegate methods or intermediate methods called via notifications and happened only when the text storage content became larger than the enclosing text view, causing scrolling to be active and "pushing" the text view to the top. After turning the option off, the "jump" was no longer observed. Hope it helps. Tom

like image 21
Tom Avatar answered Sep 22 '22 03:09

Tom