Linux shell script for loop error

Question

I'm trying to create a for loop to delete log files older than 15 days. Below is my script:

#!/bin/sh
path="/home/test"

logpath="$path/logs"
for logfile in `find $logpath -mtime +14 -type f -name *.log`
do
    echo "Deleting Log File: " $logfile
    rm -rf $logfile
done

It keeps throwing an error:

find: paths must precede expression
Usage: find [-H] [-L] [-P] [path...] [expression]

Any ideas?

Answer 1

Please try this - added single quotes

#!/bin/sh
path="/home/test"

logpath="$path/logs"
for logfile in `find $logpath -mtime +14 -type f -name '*.log'`
do
    echo "Deleting Log File: " $logfile
    rm -rf $logfile
done

Answer 2

You could use the exec param of find to get rid of the for loop:

find $logpath -mtime +14 -type f -name '*.log' -exec rm -rf {} \;

or like @Patryk Obara says :

find $logpath -mtime +14 -type f -name '*.log' -delete

which enable -depth implicitly.

You can test it like this :

mkdir test
cd test
touch test1.log
touch test2.log
find . -type f -name '*.log'
ls
> test1.log  test2.log
find . -type f -name '*.log' -delete
> empty