laravel query with closure

Question

I'm trying to query database and make a filter in a closure function, my model (Simplified) looks like this:

Products:
    id,
    sale_id

Sales:
    id,
    provider_id

Provider:
    id

I wanna all the products from a specific provider, so i've constructed this my query:

Product::with(array
           ('sale'=>function($query){
                $query->where('provider_id', '=', 1);
            })
        )->get();

the problem is that the result contains the right products with the sale, and the wrong products with the sale null, like this:

[{
    "id": 25,
    "sale": null
},
{
    "id": 26,
    "sale": {
        "id": 15,
        "provider_id": 3
    }
}]

products with sale:null are the products from another provider, I could filter them in memory, but I think there is a way to avoid the null results from the query, any clue?

Answer 1

You need to add check about sale exists whereHas('sale') and apply condition about specific provider:

Product::whereHas('sale', function($query) { 
    $query->where('provider_id', '=', 1); }
)->get();