Jquery each and attr functions

Question

I have this html:

<input id="testme" test="something"/><label test="something2"></label>

and this js

$("[test]").each(alert($(this).attr("test")));

demoed here:

jsfidde

I would think the alert would give me "something" and then "something2". But it does nothing!

What is going on?

Answer 1

You are alerting the wrong thing. The each simply returns the collection/jQuery. You would need to alert inside the each callback to alert the values of the custom attribute. Also. Please use the data- prefix when assigning [custom attributes][1] for better standards compliance.

$(".classname").each(function(){
    alert($(this).attr("classname"));
});

Answer 2

.each() takes a function, it should look like this instead:

$("[test]").each(function() {
  alert($(this).attr("test"));
});

You can test it out here.