Javascript: Creating a function with state

Question

I want to build a javascript function that maintains state. Here's a pattern that I've come up with, but something in the back of my mind tells me this is an anti-pattern.

function f() { 
    var state = 1;
    f = function() {
        return state++;
    };
    return f();
};

Is there anything wrong with this? If so, what's a better approach?

Answer 1

Well it's a matter of opinion what the best way is, but (although I know it works) I'm a little uncomfortable with having the function overwrite itself. A similar pattern that doesn't do that but still uses practically the same closure idea is this:

var f = function() {
           var state = 1;
           return function() {
              return state++;
           };
        }();

Or here is another way:

function f() {
   return f.state++;
}
f.state = 1;

Of course with the f.state method the advantage and disadvantage (depending on your needs) is that the .state property can be read and modified by other code.