Java Ternary Operator to set True or false

Question

I am trying to set a condition and set true or false as follows but it returns false all the time.

boolean checked = (categoriesCursor.getString(3) == "1") ? true
                    : false;

Log.i("Nomad",categoriesCursor.getString(3)+ " "+checked);

When i try to output the values i get the following.

01-12 00:05:38.072: I/Nomad(23625): 1 false
01-12 00:05:38.072: I/Nomad(23625): 1 false
01-12 00:05:38.072: I/Nomad(23625): 1 false
01-12 00:05:38.072: I/Nomad(23625): 1 false
01-12 00:05:38.072: I/Nomad(23625): 1 false
01-12 00:05:38.072: I/Nomad(23625): 0 false
01-12 00:05:38.072: I/Nomad(23625): 0 false

Answer 1

It returns false all the time because you are comparing references, not strings. You probably meant this instead:

boolean checked = (categoriesCursor.getString(3).equals("1")) ? true
                : false;

Which happens to be equivalent to this:

boolean checked = categoriesCursor.getString(3).equals("1");

And in case categoriesCursor.getString(3) may be null, you will be safer doing this instead:

boolean checked = "1".equals(categoriesCursor.getString(3));

Answer 2

Use equals instead of ==

boolean checked = (categoriesCursor.getString(3).equals("1"));