Menu
Why is starting a new thread in a constructor frowned upon in Java (or anywhere, for that matter). I'm getting warnings from Netbeans for doing so, but it isn't giving me any refactoring suggestions. I'm writing a client/server Swing application, and the thread I'm starting is in the server's JFrame constructor, in order to continuously listen for client datagrams.
Why is this not good practice and how should I avoid it?
389
There's nothing inherently wrong with creating a Thread inside a constructor. However, it's highly discouraged to start it immediately, as most of the time, we end up with an escaped this reference, either explicitly or implicitly.
There are mainly Three ways to create a new thread: (1) By implementing Runnable interface in your class. (2) By extending Thread class. (3) By using inner class.
Starting a thread from the constructor lets the started thread access the object being constructed before it's properly constructed, and thus makes a not completely constructed object available to the new thread.
You could create the thread in the constructor, and provide a "startup" method to start the thread from the outside.
Or you could make the constructor and startup methods private and provide a static factory method which would create the object, start the thread, and return the created object.
67
Have a look at this link http://www.ibm.com/developerworks/java/library/j-jtp0618/index.html#code4
This is do with implicit references to this and subclassing.
40
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With
