I have the following code inside a loop statement.
In the loop, strings are appended to sb(StringBuilder) and checked whether the size of sb has reached 5MB.
if (sb.toString().getBytes("UTF-8").length >= 5242880) {
// Do something
}
This works fine, but it is very slow(in terms of checking the size)
What would be the fastest way to do this?
You can calculate the UTF-8
length quickly using
public static int utf8Length(CharSequence cs) {
return cs.codePoints()
.map(cp -> cp<=0x7ff? cp<=0x7f? 1: 2: cp<=0xffff? 3: 4)
.sum();
}
If ASCII characters dominate the contents, it might be slightly faster to use
public static int utf8Length(CharSequence cs) {
return cs.length()
+ cs.codePoints().filter(cp -> cp>0x7f).map(cp -> cp<=0x7ff? 1: 2).sum();
}
instead.
But you may also consider the optimization potential of not recalculating the entire size, but only the size of the new fragment you’re appending to the StringBuilder
, something alike
StringBuilder sb = new StringBuilder();
int length = 0;
for(…; …; …) {
String s = … //calculateNextString();
sb.append(s);
length += utf8Length(s);
if(length >= 5242880) {
// Do something
// in case you're flushing the data:
sb.setLength(0);
length = 0;
}
}
This assumes that if you’re appending fragments containing surrogate pairs, they are always complete and not split into their halves. For ordinary applications, this should always be the case.
An additional possibility, suggested by Didier-L, is to postpone the calculation until your StringBuilder
reaches a length of the threshold divided by three, as before that, it is impossible to have a UTF-8
length greater than the threshold. However, that will be only beneficial if it happens that you don’t reach threshold / 3
in some executions.
If you loop 1000 times, you will generate 1000String, then convert into "UTF-8 Byte" array, to get the length.
I would reduce the conversion by storing the first length. Then, on each loop, get the length of the added value only, then this is just an addition.
int length = sb.toString().getBytes("UTF-8").length;
for(String s : list){
sb.append(s);
length += s.getBytes("UTF-8").length;
if(...){
...
}
}
This would reduce the memory used and the conversion cost
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With