Is too many params in a constructor for a factory a code smell? [closed]

Question

I have a factory class that currently takes 6 params in it's constructor, and I just hit a need to add another.

Normally, this would scream to me "Hey, your class has too many dependencies, therefore, it does too much!"

However, given this class is strictly a factory, is that really the case? Should I be concerned about the growing number of dependencies? If so, what strategies should I consider for refactoring this?

Update:
I had considered the builder pattern, but for a factory, isn't that overkill?

(Ie., WidgetFactoryBuilder, which builds a factory which builds widgets.).

Additionally, I don't understand how a builder really alleviates my dependencies - it just moves them from the constructor to methods -- which seems to obfuscate things more -- however this could be down to a poor understanding of how to apply the builder pattern in this situation.

Answer 1

• consider grouping your parameters (whatever makes sense) into FactoryConfigurationObject of some kind
• if that fails, consider using Builder pattern
• but generally yes, above 3 parameters begins to smell...

Answer 2

First of all, I should mention that I don't necessarily think six parameters are too many. But if you insist...

I don't think the problem at all lies in the number of parameters to the constructor.

The builder pattern that others recommend is useful for classes that contain a lot of state. This is rarely the case for a factory. I am instead going to assume that the parameters you are talking about are dependencies on other classes. The real problem is that your factory has too many dependencies - not that its constructor takes too many arguments.

Instead you need to look at design. Why does the factory have so many dependencies? Is it possible to reduce that number somehow? Maybe the objects that the factory creates are themselves too complex?