Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Is returning a Task violating the CQS-principle?

  • The CQS-principle (https://en.wikipedia.org/wiki/Command%E2%80%93query_separation) states that a command should return void.
  • The recommendation for async methods is to never return void (https://msdn.microsoft.com/en-us/magazine/jj991977.aspx), but instead returning a Task.

So, if I write an async command, will that inevitably break the CQS-principle?

like image 940
Emil Lundin Avatar asked Nov 23 '15 14:11

Emil Lundin


2 Answers

When dealing with async Task represents void and Task<T> represents "a result". So no, it does not violate CQS you just need to think of Task as void.

like image 139
Scott Chamberlain Avatar answered Sep 30 '22 13:09

Scott Chamberlain


At the level of considering what you want to know (a query) or do (a command) then Task<T> gives you data and hence is correct for a query and Task does not and hence is correct for a command. ("return void" is the language-specific way for some langauges to express "do not return data").

At the level below that, in which you are considering the mechanism by which asynchronous operations are managed, then you always want to have information about the state of the asynchronous operation and so always want some sort of task object. That is not the level to consider command-query separation.

Comparably, if a .NET method called into a COM method it would be calling into code that always returned a value indicating success or failure. That is just an implementation detail of how exception-handling happens in that particular technology. It's either vital or irrelevant to think about this depending on the level you are working at. Task is an implementation detail of how task-based asynchronous programming works. It's either vital or irrelevant to think about this depending on the level you are working at.

The level at which you need to think about "is this a command or a query", Task is an implementation-detail about how you get void.

like image 27
Jon Hanna Avatar answered Sep 30 '22 15:09

Jon Hanna