Is Resharper correct?

Question

I just installed Reshaper 4.5 and it has come up with the following suggestions:

return this.GetRuleViolations().Count() == 0; -- REMOVE this.

new string[] { this.ID.ToString(), this.Registration } -- REMOVE string, MAKE ANONYMOUS TYPE

int i = Method.GetNumber(); -- REPLACE int WITH var

Should I do these?

I think in some cases it is going to make the code less readable but will it improve performance? what are the benefits of making these changes?

Thanks

Answer 1

1) The explicit this pointer is only necessary when the reference would otherwise be ambiguous. Since GetRuleViolations is defined on the type, you most likely do not need this.

Another point here is that if GetRuleViolations return an IEnumerable of something, you will generally be much better off using Any() instead of Count() == 0 as you risk enumerating the entire sequence.

2) String can be inferred from the initialization.

3) Resharper prefers var over specific types.